…re severity

Introduce @DeprecatedConfig(replacement, since) on SPI getters and replace
the manually-maintained rule list in DeprecatedTableConfigValidationUtils
with a Jackson-aware reflection walk over TableConfig. Severity is decided
by comparing the annotation since against PinotVersion.VERSION major.minor
so deprecations from the current release line are warnings and older ones
are errors.

Wire both create and update paths to validate against deprecated keys.
Update paths diff incoming JSON against the byte-faithful stored ZNRecord
JSON via the new TableConfigSerDeUtils.toRawJsonNode + getTableConfigZNRecord
so legacy values left over on existing tables don't trigger false-positive
"newly introduced" errors on every PUT. Surface non-fatal warnings via
ConfigSuccessResponse.deprecationWarnings.

- Drop String.format and full request body from "Invalid TableConfigs"
  error messages; match the pattern used by addConfig (per apache#14404).
- Parameterize DeprecatedTableConfigValidationUtilsTest with a
  @dataProvider over every rule discovered by the annotation walk so
  test coverage tracks the rule list 1:1.

- copyTable: catch IllegalArgumentException (not IllegalStateException)
  to keep deprecated-config rejection at 400 instead of falling through
  to the generic 500 handler.
- DeprecatedTableConfigValidationUtils Javadoc: align documented exception
  type with the actual IllegalArgumentException thrown by validateOnCreate
  / validateOnUpdate.
- @DeprecatedConfig: restrict @target to METHOD only, since the discovery
  walk only inspects methods. Prevents misleading field-level annotations
  that would silently never fire.
- Stream realtime example configs: change segmentAssignmentConfigMap key
  from REALTIME to COMPLETED. The map is keyed by assignment type, not
  table type; SegmentAssignmentStrategyFactory looks it up via
  assignmentType.toUpperCase() so REALTIME entries were dead.

DeprecatedTableConfigValidationUtils:
- Scoped isJacksonDefault skip to apply only when stored value is absent
  (oldValue == null) so a deliberate flip of an existing non-default
  value back to the default is still flagged.
- Tightened isJacksonDefault numeric checks: short/int/long via
  longValue(); BigInteger / BigDecimal via dedicated zero comparisons;
  floating-point via Double.compare so -0.0 is non-default. Avoids the
  lossy double coercion of arbitrary-precision types.
- Tightened textual branch to match Jackson NON_DEFAULT: only explicit
  null is default for null-default String fields; empty string is a
  real user value and must be flagged on update.
- Added classifySeverity(String, String) test seam so the version-
  unknown WARNING fallback can be unit-tested.
- Updated class-level Javadoc to describe the WARNING fallback when the
  running Pinot version is unknown (was previously documented as ERROR).

PinotTableRestletResource / TableConfigsRestletResource:
- Split BAD_REQUEST catches so ZK transient failures (RuntimeException
  from getTableConfigZNRecord / validate helpers) propagate as 5xx
  instead of being mis-reported as 400.
- Added warn-log + ControllerMeter increment on each new RuntimeException
  catch so on-call observability is preserved.
- Capture JsonNode view of the request body once on update path to avoid
  double-parse before the deprecation diff.
- Removed dead uppercase fallback in subConfigJson; added Javadoc
  pointing to the deserialization invariant it relies on.
- Removed unreleased legacy validateNoDeprecatedConfigs(JsonNode[, String])
  shims; one remaining caller (copyTable) inlined to validateOnCreate.

ConfigSuccessResponse:
- Moved @JsonInclude(NON_EMPTY) from field to getter so empty
  deprecationWarnings are correctly elided from the wire.
- Normalised null _unrecognizedProperties to Map.of().

@DeprecatedConfig SPI annotation:
- Restricted @target to METHOD only (matches discovery).
- Added "metadata-only" Javadoc note clarifying that the annotation has
  no runtime serialization effect.

Tests:
- Parameterized DeprecatedTableConfigValidationUtilsTest over discovered
  rules, exercising both array-wildcard and map-wildcard JSON shapes.
- Added regression coverage for the new isJacksonDefault skip semantics
  (re-submitted default, deliberate flip, explicit JSON null on stored
  side, empty string on textual paths).
- Added testSeverityFallsBackToWarningWhenCurrentVersionUnknown +
  testSeverityWithExplicitCurrentVersion locking the WARNING fallback.
- Added ConfigSuccessResponseTest for NON_EMPTY behavior + null
  normalisation.
- Added testUppercaseOfflineRealtimeKeysAreIgnoredByJackson in
  TableConfigsSerializationTest locking the invariant subConfigJson
  relies on.

Quickstart configs (4 stream realtime examples): segmentAssignmentConfigMap
key changed from REALTIME to COMPLETED (the map is keyed by assignment
type, not table type; SegmentAssignmentStrategyFactory looks it up via
assignmentType.toUpperCase() so REALTIME entries were dead).

PUT to a nonexistent table whose body included a deprecated key was
returning a misleading 400 ("Newly introduced deprecated table config
properties are not allowed: ...") because the deprecation diff ran with
oldTableConfigJson==null (which fell through to create-mode) before
the hasTable() check.

- PinotTableRestletResource.updateTableConfig: hasTable check moved
  above the deprecation diff so missing table reports 404 cleanly.
- TableConfigsRestletResource.updateConfig: symmetric reorder so
  missing table reports the existing "does not exist" 400 instead of
  a deprecation 400.
- DeprecatedTableConfigValidationUtils.validateOnUpdate: tightened
  contract to reject null oldTableConfigJson so callers cannot
  accidentally exercise create-mode under update semantics.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

- PinotTableRestletResourceTest.testUpdateMissingTableReports404NotDeprecationError:
  regression for the recent existence-check reorder; PUT to a missing
  table whose body has a deprecated key now reports 404 cleanly.
- TableConfigsRestletResourceTest.testUpdateConfigRejectsNewlyIntroducedDeprecatedProperty:
  symmetric to the create-mode rejection, asserts a PUT that introduces
  a new deprecated key on an existing TableConfigs returns 400 with the
  deprecated path in the message.
- TableConfigsRestletResourceTest.testUpdateMissingTableConfigsReportsNotExistsNotDeprecation:
  regression for the symmetric reorder in TableConfigsRestletResource;
  PUT to a missing TableConfigs reports "does not exist" instead of a
  misleading deprecation 400.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…uency

CI surfaced a wider issue with the TableConfigBuilder rewrite that was
bundled with this PR: ~14 realtime integration tests rely on reading
indexingConfig.streamConfigs after building a config via the builder, so
removing the legacy population from build() broke their setUp().

Rather than migrate every test to read from
ingestionConfig.streamIngestionConfig in this PR, remove the three
deprecation annotations whose enforcement requires the builder rewrite,
and revert TableConfigBuilder.build() to its prior shape that populates
the legacy fields. The remaining @DeprecatedConfig annotations
(replicasPerPartition, jsonIndexColumns, indexType, etc.) still validate
on create + update via the diff-based version-aware path.

The dropped deprecations can ship in a follow-up PR after the codebase
migrates fully to the ingestionConfig shape.

- pinot-spi: drop @DeprecatedConfig from getStreamConfigs(),
  getSegmentPushType(), getSegmentPushFrequency()
- pinot-spi: revert TableConfigBuilder.build() to populate
  validationConfig.{segmentPushType,segmentPushFrequency} and
  indexingConfig.streamConfigs
- pinot-controller tests: migrate path-specific assertions from
  segmentPushType/streamConfigs to replicasPerPartition (still
  deprecated since 1.1.0)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

testBuildConvertsDeprecatedIngestionFields was added when the builder
auto-routed legacy ingestion fields into ingestionConfig. The previous
commit reverted that rewrite, so the test now contradicts the reverted
behavior. testBuildOmitsDefaultDeprecatedFieldsFromSerializedJson
remains valid because it depends on @JsonInclude(NON_DEFAULT) on the
beans, not on the builder's ingestion routing.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

The CI failure surface revealed that Pinot's own integration tests
(CommitTimeCompactionIntegrationTest, dedup/upsert tests, controller
periodic tasks) actively use deprecated table-config setters
(setReplicaGroupStrategyConfig, setReplicasPerPartition, etc.). Hard
ERROR rejection on create blocks every one of those tests with 400.

Demote classifySeverity so every parseable @DeprecatedConfig.since
returns WARNING. Only an unparseable since (a code-side annotation
bug) remains ERROR. The validator still surfaces every deprecated key
as a warning on both create and update — just no longer rejects.

Hard ERROR enforcement (the originally-designed older-than-current
threshold) can ship in a follow-up PR after the test base and
TableConfigBuilder migrate off the deprecated paths.

- DeprecatedTableConfigValidationUtils.classifySeverity: drop
  current-major-minor comparison; always return WARNING for parseable
  since
- DeprecatedTableConfigValidationUtilsTest: rewrite tests asserting
  ERROR semantics to assert WARNING semantics; consolidate the two
  current-version tests into one soft-launch test
- PinotTableRestletResourceTest.testReportsDeprecatedConfigOnCreate-
  AndOnUpdateAsWarning: assert deprecationWarnings field on success
  response instead of 400 rejection
- TableConfigsRestletResourceTest: same shape change for the create
  + update tests on /tableConfigs

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Restore the streamConfigs @DeprecatedConfig rule now that the validator soft-launches parseable deprecations as warnings instead of rejecting builder-produced legacy configs.

Teach update diffing to treat legacy fieldConfigList[].indexType as unchanged when the stored JSON has an equivalent singleton indexTypes array, preserving idempotent updates after @JsonIgnore serialization.

Keep the pauseless / logical-table setStreamConfigs(null) regression fix from the amended commit.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…ard, default-value test

Three review findings addressed:

1. validate endpoints no longer echo the raw request body (which can carry
   stream credentials) into 400 responses or controller logs. Both
   PinotTableRestletResource.checkTableConfig and TableConfigsRestletResource.
   validateConfig now use "Invalid ... json string. " + e.getMessage() instead
   of String.format with the full tableConfigStr.

2. TableConfigsRestletResource.validateConfig now runs the permission check
   BEFORE validateNoDeprecatedConfigs (which reads stored configs from ZK).
   Prevents an unauthenticated caller from probing table existence via the
   deprecation-diff response shape, and matches the ordering already used in
   PinotTableRestletResource.checkTableConfig. setTableName is still deferred
   until after validateConfig because it has the side effect of overwriting
   the embedded schema name, which would mask the schema-mismatch check.

3. isJacksonDefault is exposed as a package-private static method, and a new
   regression test testEveryAnnotatedGetterHasJavaZeroDefault iterates every
   discovered @DeprecatedConfig rule, instantiates the leaf bean via its
   no-arg constructor, invokes the leaf getter, and asserts the Java default
   value is treated as default by isJacksonDefault. Locks in the contract
   so a future contributor who annotates a non-zero-default getter fails at
   test time rather than silently suppressing diffs at runtime. The rule
   record now carries the owning bean class + leaf getter Method for tests
   to introspect.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

After rebase onto upstream/master, Jackson's default field ordering
changed and the integration tests that assert byte-exact response JSON
broke. Explicit @JsonPropertyOrder(unrecognizedProperties,
deprecationWarnings, status) makes the wire shape deterministic across
Jackson versions and keeps the pre-deprecationWarnings layout that
existing clients depend on.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>